MVVM RxSwift Architechture #6

daolq3012 · 2018-04-10T09:49:21Z

CleanArchitectureMVVMRxSwift
base on: sergdort/CleanArchitectureRxSwift

houndci-bot · 2018-04-10T09:50:18Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+                    switch result {
+                    case .success(let response):
+                        self?.navigator.toListUser(users: response?.users)
+                    case .failure(_): break


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-04-10T09:50:18Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+        }
+
+        let inputRequest = Driver.combineLatest(input.keyword, input.limitNumber) {
+            (keyword, limitNumber) -> SearchRequest in


Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)

houndci-bot · 2018-04-10T09:50:18Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

+        let navigator = DefaultSearchNavigator(navigationController: self.navigationController)
+        viewModel =  SearchViewModel(userRepository: userRepository, navigator: navigator)
+
+        let input = SearchViewModel.Input(keyword: searchTextField.rx.text.orEmpty.asDriver(), limitNumber: limitNumberTextField.rx.text.orEmpty.asDriver(), searchTrigger: searchButton.rx.tap.asDriver())


Line Length Violation: Line should be 120 characters or less: currently 203 characters (line_length)

houndci-bot · 2018-04-10T09:50:18Z

src/Structure_IOS/Repositories/UserRepository.swift

-    func searchUsers(keyword: String, limit: Int, completion: @escaping (BaseResult<SearchResponse>) -> Void) {
-        let input = SearchRequest(keyword: keyword, limit: limit)
-
+    func searchUsers(input: SearchRequest, completion: @escaping (BaseResult<SearchResponse>) -> Void){        


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

houndci-bot · 2018-04-12T07:44:55Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+        let activityIndicator = ActivityIndicator()
+
+        let canSearch = Driver.combineLatest(keywordAndLimitNumber, activityIndicator.asDriver())
+        { (keywordAndLimitNumber, activityIndicator) in


Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

houndci-bot · 2018-04-12T07:44:55Z

src/Structure_IOS/Extensions/ObservableExtension.swift

+    }
+
+    func asDriverOnErrorJustComplete() -> Driver<E> {
+        return asDriver { error in


Unused Closure Parameter Violation: Unused parameter "error" in a closure should be replaced with _. (unused_closure_parameter)

houndci-bot · 2018-04-12T07:44:55Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

-                                completion(nil, BaseError.apiFailure(error: error))
+
+        return Observable.create {observer in
+            self.alamofireManager.request(input.url, method: input.requestType, parameters: input.body, encoding: input.encoding)


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2018-04-12T07:44:56Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

-                    } else {
-                        completion(nil, BaseError.unexpectedError)
+                        observer.on(.completed)
+                    case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-04-12T07:44:56Z

src/Structure_IOS/Utils/Reactive/ActivityIndicator.swift

+import RxCocoa
+
+public class ActivityIndicator: SharedSequenceConvertibleType {
+    public typealias E = Bool


Type Name Violation: Type name should be between 3 and 40 characters long: 'E' (type_name)

houndci-bot · 2018-04-12T07:44:56Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+        let activityIndicator = ActivityIndicator()
+
+        let canSearch = Driver.combineLatest(keywordAndLimitNumber, activityIndicator.asDriver())
+        { (keywordAndLimitNumber, activityIndicator) in


Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

houndci-bot · 2018-04-12T07:44:56Z

src/Structure_IOS/Extensions/ObservableExtension.swift

+    }
+
+    func asDriverOnErrorJustComplete() -> Driver<E> {
+        return asDriver { error in


Unused Closure Parameter Violation: Unused parameter "error" in a closure should be replaced with _. (unused_closure_parameter)

houndci-bot · 2018-04-12T07:44:56Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

-                                completion(nil, BaseError.apiFailure(error: error))
+
+        return Observable.create {observer in
+            self.alamofireManager.request(input.url, method: input.requestType, parameters: input.body, encoding: input.encoding)


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2018-04-12T07:44:57Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

-                    } else {
-                        completion(nil, BaseError.unexpectedError)
+                        observer.on(.completed)
+                    case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-04-12T08:47:32Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+            }).mapToVoid()
+
+        return SearchViewModel.Output(searchButtonEnable: canSearch, errorInputNumber: errorInputNumber,
+                                      search: search, error: errorTracker.asDriver(), dissmiss: activityIndicator.asDriver())


Line Length Violation: Line should be 120 characters or less: currently 125 characters (line_length)

houndci-bot · 2018-04-12T08:47:32Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

+    }
+
+    var errorBinding: Binder<Error> {
+        return Binder(self, binding: { (vc, error) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T08:47:33Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

-                    }
-                }
+    var errorInputNumberBinding: Binder<String> {
+        return Binder(self, binding: { (vc, errorText) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T08:47:33Z

src/Structure_IOS/Extensions/ObservableExtension.swift

+
+    /// Bindable sink for `show()`, `hide()` methods.
+    public static var isAnimating: Binder<Bool> {
+        return Binder(UIApplication.shared) { progressHUD, isVisible in


Unused Closure Parameter Violation: Unused parameter "progressHUD" in a closure should be replaced with _. (unused_closure_parameter)

houndci-bot · 2018-04-12T08:47:33Z

src/Structure_IOS/Scenes/Search/SearchViewModel.swift

+            }).mapToVoid()
+
+        return SearchViewModel.Output(searchButtonEnable: canSearch, errorInputNumber: errorInputNumber,
+                                      search: search, error: errorTracker.asDriver(), dissmiss: activityIndicator.asDriver())


Line Length Violation: Line should be 120 characters or less: currently 125 characters (line_length)

houndci-bot · 2018-04-12T08:47:33Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

+    }
+
+    var errorBinding: Binder<Error> {
+        return Binder(self, binding: { (vc, error) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T08:47:34Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

-                    }
-                }
+    var errorInputNumberBinding: Binder<String> {
+        return Binder(self, binding: { (vc, errorText) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T08:47:34Z

src/Structure_IOS/Extensions/ObservableExtension.swift

+
+    /// Bindable sink for `show()`, `hide()` methods.
+    public static var isAnimating: Binder<Bool> {
+        return Binder(UIApplication.shared) { progressHUD, isVisible in


Unused Closure Parameter Violation: Unused parameter "progressHUD" in a closure should be replaced with _. (unused_closure_parameter)

houndci-bot · 2018-04-12T13:52:37Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

-                    }
-                }
+    var errorBinding: Binder<Error> {
+        return Binder(self, binding: { (vc, error) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T13:52:37Z

src/Structure_IOS/Scenes/Search/SearchViewController.swift

+    }
+
+    var errorInputNumberBinding: Binder<String> {
+        return Binder(self, binding: { (vc, errorText) in


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)

houndci-bot · 2018-04-12T13:52:37Z

src/Structure_IOS/Scenes/ListUser/ListUsersViewController.swift

-            print(user)
-        }
+        let output = viewModel.transform(input: input)
+        output.users.drive(tableView.rx.items(cellIdentifier: ListUsersTableViewCell.reuseID, cellType: ListUsersTableViewCell.self)) { (_, viewModel, cell) in


Line Length Violation: Line should be 120 characters or less: currently 159 characters (line_length)

houndci-bot · 2018-04-12T13:52:38Z

src/Structure_IOS/Scenes/ListUser/ListUserViewModel.swift

+
+        let userItemViewModels = Observable.just(self.users).asDriverOnErrorJustComplete()
+            .map { $0.map { UserItemViewModel(with: $0) }}
+        let selectedCell = input.selection.withLatestFrom(userItemViewModels) { (indexPath, userItemViewModels) -> User in


Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)

houndci-bot · 2018-04-12T13:56:22Z

src/Structure_IOS/Scenes/ListUser/ListUserViewModel.swift

+        let userItemViewModels = Observable.just(self.users).asDriverOnErrorJustComplete()
+            .map { $0.map { UserItemViewModel(with: $0) }}
+        let selectedCell = input.selection.withLatestFrom(userItemViewModels)
+        { (indexPath, userItemViewModels) -> User in


Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

houndci-bot · 2018-04-13T18:00:38Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

-                    break
+                }
+            }, usingThreshold: UInt64.init(), to: input.url) { (result) in
+                switch result{


Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

houndci-bot · 2018-04-13T18:00:38Z

src/Structure_IOS/Data/Source/Remote/Service/APIService.swift

                    }
-                    break
+                }
+            }, usingThreshold: UInt64.init(), to: input.url) { (result) in


Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument. (multiple_closures_with_trailing_closure)

houndci-bot · 2018-04-19T04:43:06Z

src/Structure_IOS/Scenes/ListUser/ListUsersViewController.swift

+                (cell as! ListUsersTableViewCell).bind(viewModel: element)
+            } else {
+                cell = tableView.dequeueReusableCell(withIdentifier: ListUsersTableViewCell.reuseID, for: indexPath)
+                (cell as! ListUsersTableViewCell).bind(viewModel: element)


Force Cast Violation: Force casts should be avoided. (force_cast)

houndci-bot · 2018-04-19T04:43:06Z

src/Structure_IOS/Scenes/ListUser/ListUsersViewController.swift

+            var cell: UITableViewCell!
+            if indexPath.row == 1 {
+                cell = tableView.dequeueReusableCell(withIdentifier: ListUsersTableViewCell.reuseID, for: indexPath)
+                (cell as! ListUsersTableViewCell).bind(viewModel: element)


Force Cast Violation: Force casts should be avoided. (force_cast)

houndci-bot reviewed Apr 10, 2018

View reviewed changes

houndci-bot reviewed Apr 12, 2018

View reviewed changes

daolq3012 force-pushed the mvvm_architect branch from 03db6a4 to a7b97b8 Compare April 12, 2018 08:04

Repository owner deleted a comment from houndci-bot Apr 12, 2018

daolq3012 force-pushed the mvvm_architect branch from a7b97b8 to a4ecea4 Compare April 12, 2018 08:08

Repository owner deleted a comment from houndci-bot Apr 12, 2018

daolq3012 force-pushed the mvvm_architect branch from a4ecea4 to d6c3145 Compare April 12, 2018 08:47

houndci-bot reviewed Apr 12, 2018

View reviewed changes

daolq3012 force-pushed the mvvm_architect branch 2 times, most recently from 7f98926 to 776251c Compare April 12, 2018 13:52

houndci-bot reviewed Apr 12, 2018

View reviewed changes

daolq3012 force-pushed the mvvm_architect branch from 776251c to 4418039 Compare April 12, 2018 13:56

houndci-bot reviewed Apr 12, 2018

View reviewed changes

daolq3012 force-pushed the mvvm_architect branch 2 times, most recently from 5147a89 to 1a2c86c Compare April 13, 2018 18:00

houndci-bot reviewed Apr 13, 2018

View reviewed changes

daolq3012 force-pushed the mvvm_architect branch 3 times, most recently from 2db03db to 8fe33e7 Compare April 19, 2018 04:42

houndci-bot reviewed Apr 19, 2018

View reviewed changes

MVVM Architect

56673d7

daolq3012 force-pushed the mvvm_architect branch from 8fe33e7 to 56673d7 Compare April 20, 2018 02:55

MVVM RxSwift Architechture #6

Are you sure you want to change the base?

MVVM RxSwift Architechture #6

Uh oh!

Conversation

daolq3012 commented Apr 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daolq3012 commented Apr 10, 2018 •

edited

Loading